fix(list): update keybindings when setting items #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Stewart <christian@paral.in>
Bug: when calling SetItems when items was previously empty, the keybindings for up/down do not appear. Fix: call updateKeybindings in SetItems. Signed-off-by: Christian Stewart <christian@paral.in>
meowgorithm
reviewed
Jan 4, 2022
|
Good catch! This generally looks right. We’ll merge once we verify. Thanks for the PR! |
|
@meowgorithm after extensive testing I can confidently say this was the fix. |
|
Thanks so much, @paralin. Would it be possible to provide some sample code we could use to verify the fix with over here? This will help us accelerate getting this ticket merged. |
|
@meowgorithm just create a bubbles list of length 0, then call AddItem to add an item (in Update). |
|
Thanks so much for the fix! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: when calling SetItems when items was previously empty, the keybindings for
up/down do not appear.
Fix: call updateKeybindings in SetItems.