Handling terminal resizes on Windows #538

aschey · 2022-10-14T14:51:32Z

Since the PR to handle input records on Windows wasn't merged, would there be any interest in using a simple polling-based approach to handle resizes on Windows? Basically something like this:

w, h, err := term.GetSize(int(f.Fd()))
for {
    time.Sleep(500 * time.Millisecond)
    newW, newH, err := term.GetSize(int(f.Fd()))
    if newW != w || newH != h {
        w = newW
        h = newH
        msgs <- WindowSizeMsg{w, h}
    }
}

Obviously not ideal, but I think it would be nice to support resizing in some capacity. Can make it disabled by default and marked as an unstable feature if necessary.

muesli · 2022-10-14T19:36:48Z

Personally I dislike such polling based solutions, as they always feel like a bit of a hack. Obviously the current situation isn't ideal and we need to some thing about it, but I'm sure there are proper ways to get notified of a resized console on Windows. Which PR are you referring to?

aschey · 2022-10-14T20:36:29Z

Agree that it's definitely a hack, but I don't know if there's another reliable way to do it besides handling input records. This: #140 is the PR that implemented input records and would've enabled handling resizes. If there is still interest in handling input records, that would be the ideal way to solve this. But as mentioned in the comments, that would require a substantial change to the architecture around how the cancel reader now works.

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

@erikgeiser

This adds support to the Windows Console Input Buffer API which access the console API directly without the need for virtual terminal input (i.e. the current mode that emulates unix inputs). Since this uses the console input api, we can finally read window size events. This is mearly based on the awesome work of @erikgeiser in #140. Fixes: #538 Fixes: #121

meowgorithm · 2024-02-27T19:48:34Z

Just a note that this is now available in Windows courtesy #878. It's currently on master and will be included in the next release.

aschey changed the title ~~Resizing on Windows~~ Handling terminal resizes on Windows Oct 14, 2022

aymanbagabas mentioned this issue Dec 3, 2023

feat: support windows console input buffer #878

Merged

aymanbagabas closed this as completed in #878 Feb 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handling terminal resizes on Windows #538

Handling terminal resizes on Windows #538

aschey commented Oct 14, 2022

muesli commented Oct 14, 2022

aschey commented Oct 14, 2022

meowgorithm commented Feb 27, 2024

Handling terminal resizes on Windows #538

Handling terminal resizes on Windows #538

Comments

aschey commented Oct 14, 2022

muesli commented Oct 14, 2022

aschey commented Oct 14, 2022

meowgorithm commented Feb 27, 2024