-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Synchronized output #1027
base: main
Are you sure you want to change the base?
Conversation
d0a5b13
to
1f323a0
Compare
Friendly poke to whoever can keep this moving, could really use this for my TUI as it flickers pretty heavily on certain terminals. Cool to see a PR up for it already! 😄 |
@vito do you think you can give a try ? Dear maintainners, are you ok with the way the feature is implemented (wording of methods and variables) ? For the feature itself, i'm not an ansi guru, i just need to know:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out and went looking for how to enable it, and noticed it just enables itself if the terminal supports it, which makes sense to me. 👍
I think I found a typo along the way though - left a suggestion.
9ce5c92
to
a4adb3d
Compare
a4adb3d
to
74ceda3
Compare
Hey @nervo! Thanks for looking into this one, it's something we've very much been wanting to get in. API aside, the big thing that will need to happen for this feature to work is an implementation at the renderer level so that Bubble Tea can repaint in-step with the terminal. We're currently working on an overhaul to the renderer, so we should hold off on this until we've made that update. |
@meowgorithm ok, good to hear 👍 |
This is an attempt to implement synchronized output in bubbletea. At this time, this is so naive, that you can see it as a proof-of-concept :)
Anyway, this does not break on my machine 👍
Some interesting reading:
Feel free to comment ❤️