Deprecate high performance rendering feature and ANSI compressor #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance rendering is very limited in what it can do and is very hard to implement.
meowgorithm
requested review from
aymanbagabas
and removed request for
aymanbagabas
aymanbagabas
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These revisions deprecate the high performance rendering set of commands:
SyncScrollArea()ClearScrollArea()ScrollUp()ScrollDown()Performance rendering is very hard to implement, goes against Bubble Tea's Elm Architecture design patterns, and is very limited in that it can only operate on the entire width of the terminal at once (so it won't work in, say, a viewport that spans half of the terminal width).
We’re also deprecating
WithANSICompressor()as it has very noticeable performance costs which we believe outweigh the bandwidth benefits otherwise provided.