(v2) feat: query background color by default #1195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the program query the terminal for its background color by default. This is useful if you want to enable automatic background color detection for your program. It also adds a new option `WithoutBackgroundColor` to disable this behavior.
|
For the alpha, why don't we keep it opt in? If we find the friction is too high we can merge this. To your point, it would be good to avoid the heavy query when we can. |
|
Aren't users used to this behaviour by default though? I do agree that less is more overall though. Just might feel weird at first if they're used to a certain behaviour |
aymanbagabas
force-pushed
the
v2-query-bg
branch
from
f855f13
to
7cb35d7
Compare
aymanbagabas
changed the title
|
I agree with @bashbunni tbh. Since we're moving to pure lipgloss and removing the lipgloss "hack" in bubbletea@v2 that queries the terminal on start, we need to send the terminal bg color on start similar to |
bashbunni
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the program query the terminal for its background color by default. This is useful if you want to enable automatic background color detection for your program.
It also adds a new option
WithoutBackgroundColorto disable this behavior.