feat: allow to execute other things besides exec.Commands #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
muesli
pushed a commit
that referenced
this pull request
Apr 5, 2022
* feat: allow to execute other things besides exec.Commands. * fix: lint issues * fix: renames, examples Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
meowgorithm
added a commit
that referenced
this pull request
Apr 12, 2022
…rminal (#237) * add: program.ReleaseTerminal and RestoreTerminal to re-use input & terminal * chore(examples): add altscreen toggling to exec demo * chore: put low-level altscreen stuff alongside other screen funcs * docs: edit GoDocs for ReleaseTerminal and RestoreTerminal * feat(renderer): add internal Msg renderMsg to immediately repaint * fix: repaint instantly on RestoreTerminal * fix: restore the altscreen state when restoring the terminal * feat: implement Cmd-based API for blocking *exec.Cmds * feat: allow Exec to return custom messages * feat: allow Exec to be run without a callback * fix: separate parameters for exec.Command examples * fix: error message would get printed over by prompt in exec example * fix: ignore signals while child process is running * feat: allow to execute other things besides exec.Commands (#280) * feat: allow to execute other things besides exec.Commands. * fix: lint issues * fix: renames, examples * fix: callback type should be exported * docs(exce): tiny ExecCommand doc comment correction * chore(exec): break out Cmd for clarity's sake in example * fix(exec): give the terminal a moment to catch up if exiting altscreen * docs(exec): tidy up doc comments * chore(exec): disambiguate methods for restoring the terminal state vs input Co-authored-by: Christian Rocha <christian@rocha.is> Co-authored-by: Carlos A Becker <caarlos0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an interface around exec.Cmd so users can execute other things as well (i.e. any go code).
The main usecase for this that I see is for wishlist, so we can ssh into something and back to the list later instead of quitting everything :)