feat(examples): Credit Card Example Now Displays User Input Errors #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a fix that needs to happen in the upstream Bubbles repo. We are doing the validation there for the input fields and there is an open PR regarding this issue: charmbracelet/bubbles#185 Sorry for any confusion this may have caused with the credit card example. Thank you for your support!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the request of, and as a response to #654 ,
While the credit card example may have shown developers how to use the
textinputbubble, the application itself was lacking in visual feedback, both for the "user" as well as the developer.This change, gives a more natural and responsive UI for developers as they iterate on the example to further learn the library.
The first two commits are nullified, I can clean if yall'd like.