Fix race condition in standard renderer. #742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stopping the program, it would occasionally hang. Looking at the stacktrace, it is because the listen goroutine is trying to flush, which needs the mutext, but because stop() also held the mutex, it would deadlock.
collinvandyck
force-pushed
the
collin/fix-mutex-lock-issue
branch
from
69a15fc
to
54b888b
Compare
|
I think we might just want to move closing the channel above the final flush and clear line. Preparing a PR to test. |
|
Ah I like your PR much better. thanks for taking a look! |
|
Fixed in #757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #741
When stopping the program, it would occasionally hang. Looking at the stacktrace, it is because the listen goroutine is trying to
flush(), which needs the mutex, but becausestop()also held the mutex, it would deadlock.To address this we make lock aquisition a little more granular and break out the line clearing into a separate method which grabs and then releases the mutex.