fix: use a noop stats implementation if stats are disabled (#141)

* test: use a noop stats impl on testserver

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>

* fix: set a noop stats if metrics are disabled

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>

* refactor: more legible

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>

server/server.go

@@ -15,6 +15,7 @@ import (
  "github.com/charmbracelet/charm/server/db"
  "github.com/charmbracelet/charm/server/db/sqlite"
  "github.com/charmbracelet/charm/server/stats"
+ "github.com/charmbracelet/charm/server/stats/noop"
  "github.com/charmbracelet/charm/server/stats/prometheus"
  "github.com/charmbracelet/charm/server/storage"
  lfs "github.com/charmbracelet/charm/server/storage/local"
@@ -189,8 +190,7 @@ func (srv *Server) Close() error {
  return fmt.Errorf("db close error: %s", err)
  }
  if srv.Config.Stats != nil {
- err := srv.Config.Stats.Close()
- if err != nil {
+ if err := srv.Config.Stats.Close(); err != nil {
  return fmt.Errorf("db close error: %s", err)
  }
  }
@@ -214,7 +214,14 @@ func (srv *Server) init(cfg *Config) {
  }
  srv.Config = cfg.WithFileStore(fs)
  }
- if cfg.EnableMetrics && cfg.Stats == nil {
- srv.Config = cfg.WithStats(prometheus.NewStats(cfg.DB, cfg.StatsPort))
+ if cfg.Stats == nil {
+ srv.Config = cfg.WithStats(getStatsImpl(cfg))
+ }
+}
+
+func getStatsImpl(cfg *Config) stats.Stats {
+ if cfg.EnableMetrics {
+ return prometheus.NewStats(cfg.DB, cfg.StatsPort)
  }
+ return noop.Stats{}
 }

server/stats/noop/noop.go

@@ -0,0 +1,34 @@
+// Package noop provides a stats impl that does nothing.
+// nolint:revive
+package noop
+
+import (
+ "context"
+
+ "github.com/charmbracelet/charm/server/stats"
+)
+
+// Stats is a stats implementation that does nothing.
+type Stats struct{}
+
+var _ stats.Stats = Stats{}
+
+func (Stats) APILinkGen() {}
+func (Stats) APILinkRequest() {}
+func (Stats) APIUnlink() {}
+func (Stats) APIAuth() {}
+func (Stats) APIKeys() {}
+func (Stats) LinkGen() {}
+func (Stats) LinkRequest() {}
+func (Stats) Keys() {}
+func (Stats) ID() {}
+func (Stats) JWT() {}
+func (Stats) GetUserByID() {}
+func (Stats) GetUser() {}
+func (Stats) SetUserName() {}
+func (Stats) GetNewsList() {}
+func (Stats) GetNews() {}
+func (Stats) PostNews() {}
+func (Stats) Start() error { return nil }
+func (Stats) Close() error { return nil }
+func (Stats) Shutdown(_ context.Context) error { return nil }

testserver/testserver.go

@@ -107,7 +107,7 @@ func randomPort(tb testing.TB) int {
  if err != nil {
  tb.Fatalf("could not get a random port: %s", err)
  }
- listener.Close()
+ listener.Close() //nolint:errcheck
 
  addr := listener.Addr().String()