Speed up client FS, support server user max storage capacity, use authorized_keys, and some fixes #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
bufferless-fs
branch
from
ff95abf
to
0998ccc
Compare
3 tasks
aymanbagabas
force-pushed
the
bufferless-fs
branch
from
0998ccc
to
311f813
Compare
export MaxFSRequestSize
* don't check client request size, leave that to the server * use a bufferless request when writting to CharmFS https://stackoverflow.com/a/39781706/10913628 https://blog.depa.do/post/bufferless-multipart-post-in-go
aymanbagabas
force-pushed
the
bufferless-fs
branch
from
311f813
to
d56558f
Compare
use CHARM_SERVER_USER_MAX_STORAGE to set user storage capacity (in bytes) a value of zero disables user cap
"Changing the header map after a call to WriteHeader (or Write) has no effect unless the modified headers are trailers." https://pkg.go.dev/net/http#ResponseWriter
having an authorized_keys file will limit the users who can access the charm server to only those specified in the file Related: #55
aymanbagabas
force-pushed
the
bufferless-fs
branch
from
d56558f
to
86d6b7d
Compare
toby
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHARM_SERVER_USER_MAX_STORAGE, zero is the default which means storage cap is disableddata/.ssh/authorized_keysif it exists to limit user access to the server