fix: Fix invalid order of event handling in input/text fields #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key binds should be checked before the key event is accepted as user input. See charmbracelet/bubbletea#1041 for more information.
|
Thanks so much for the contribution!! |
renovate bot
referenced
this pull request
in jippi/dottie
Jul 25, 2024
….mod (#67) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/charmbracelet/huh](https://togithub.com/charmbracelet/huh) | `v0.5.1` -> `v0.5.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charmbracelet/huh (github.com/charmbracelet/huh)</summary> ### [`v0.5.2`](https://togithub.com/charmbracelet/huh/releases/tag/v0.5.2) [Compare Source](https://togithub.com/charmbracelet/huh/compare/v0.5.1...v0.5.2) ### Lil’ fixes ’n’ improvements Hi! This is a maintenance release to fix issues with dynamic forms as well as address issues with [Gum](https://togithub.com/charmbracelet/gum) upstream. #### Changelog ##### New - add accept and reject key bindings to confirm by [@​csandeep](https://togithub.com/csandeep) in [https://github.com/charmbracelet/huh/pull/308](https://togithub.com/charmbracelet/huh/pull/308) - allow Generic `T` updateOptionsMsg by [@​maaslalani](https://togithub.com/maaslalani) in [https://github.com/charmbracelet/huh/pull/318](https://togithub.com/charmbracelet/huh/pull/318) ##### Fixed - improve distinction in field select by [@​csandeep](https://togithub.com/csandeep) in [https://github.com/charmbracelet/huh/pull/304](https://togithub.com/charmbracelet/huh/pull/304) - fix invalid order of event handling in input/text fields by [@​Sculas](https://togithub.com/Sculas) in [https://github.com/charmbracelet/huh/pull/284](https://togithub.com/charmbracelet/huh/pull/284) #### New Contributors - [@​csandeep](https://togithub.com/csandeep) made their first contribution in [https://github.com/charmbracelet/huh/pull/304](https://togithub.com/charmbracelet/huh/pull/304) - [@​MaximilianSoerenPollak](https://togithub.com/MaximilianSoerenPollak) made their first contribution in [https://github.com/charmbracelet/huh/pull/313](https://togithub.com/charmbracelet/huh/pull/313) **Full Changelog**: charmbracelet/huh@v0.5.1...v0.5.2 *** <a href="https://charm.sh/"><img alt="The Charm logo" src="https://stuff.charm.sh/charm-badge.jpg" width="400"></a> Thoughts? Questions? We love hearing from you. Feel free to reach out on [Twitter](https://twitter.com/charmcli), [The Fediverse](https://mastodon.technology/@​charm), or [Discord](https://charm.sh/chat). </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key binds should be checked before the key event is accepted as user input. Otherwise, control sequences or other keys might be printed instead of being interpreted as a key bind. See the above-mentioned PR for more information.