Improve maximum width of characters in a string #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelorant
force-pushed
the
fix/maximum-width
branch
3 times, most recently
from
9137b47
to
261e1bd
Compare
|
Had to bump up to Go @charmbracelet Can I get a review of this improvement. Thanks. |
maaslalani
reviewed
Jan 31, 2024
The function `maxRuneWidth` was using a flawed approach by only evaluating strings based on each rune. The `uniseg` package provides a more accurate method based on grapheme clusters. This change switches over to the improved implementation which should achieve better results when determining the maximum width of all grapheme clusters in a string. Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
mikelorant
force-pushed
the
fix/maximum-width
branch
from
261e1bd
to
d456a5a
Compare
|
@maaslalani Changes made as requested. |
|
@maaslalani You are now my PR buddy as I move onto the next one 😆 |
|
@maaslalani Any further changes required or can we merge this now? |
|
Nice work, sir. Let’s get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
maxRuneWidthwas using a flawed approach by only evaluating strings based on each rune. Theunisegpackage provides a more accurate method based on grapheme clusters.This change switches over to the improved implementation which should achieve better results when determining the maximum width of all grapheme clusters in a string.