-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move tree to root #342
Conversation
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
If you don't mind, going to look at a few last things today before we merge this one. |
Hey @meowgorithm any changes on this one? |
Let’s get the tree examples back in as well — I'm looking at stuff now. |
@meowgorithm kk no rush. Just added the examples back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feeling good! Let's get this done ⚡️
Removed If we did want to fix this we could replace this whitespace rendering with calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO before merge
- tidy godoc (some tree docs mention list)
- tidy godoc - opened a PR against this branch with improvements
- show an example of unique styling of the root element (this might be broken)
- add tree info to
README.md
I thought the lipgloss root styling might be broken because if we do ItemStyleFunc(func(children tree.Children, i int) lipgloss.Style {
if children.At(i).Value() == "Nyx" {
return itemStyle.Background(lipgloss.Color("#04B575"))
}
return itemStyle
}) we get
because when we're on the root item, it's As-is we will always need to do a root value check in |
We might even want to see about separating out |
i think that makes more sense yes |
closes #339
closes #341