(v2) fix(examples): make examples use v2 #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a helper type `LightDark` that takes a boolean to determine which `Color(light, dark)` to choose from. The `adaptive` package is a helper package that uses the `lipgloss.LightDark` along with querying the terminal when the module is imported to choose the appropriate light-dark color. Example: ```go var ( light = "#0000ff" dark = "#ff0000" ) colorToUse := adaptive.Color(light, dark) // the terminal is queried before choosing the color fmt.Println(colorToUse) ```
|
I also had to update log @ |
aymanbagabas
changed the title
Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
Co-authored with @aymanbagabas
meowgorithm
force-pushed
the
v2-examples
branch
from
83606ac
to
d724ce6
Compare
|
Rebased on |
|
@bashbunni so the work here has been merged into #397, which contains solutions we're working though for adaptive colors, printers, and additional fixes for the open items here that were (excellently) documented. In other words, for all intended and purposes, it’s the leading v2 branch right ow. Are you cool if I open a PR for that branch and supersede this one? |
|
@meowgorithm yeah totally cool! If we don't need this branch anymore we can close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: get the examples working for v2
Only thing outstanding is clarifying how to work with light and dark backgrounds + detecting background color with v2. On that note, #359 is related to this PR