Update slog code to work with Go 1.21 #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements slog.Handler interface. You can use Log as an slog handler.
Closed
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## slog #74 +/- ##
==========================================
- Coverage 74.70% 74.59% -0.12%
==========================================
Files 10 10
Lines 672 673 +1
==========================================
Hits 502 502
- Misses 154 155 +1
Partials 16 16
☔ View full report in Codecov by Sentry. |
jamietanna
commented
Sep 20, 2023
| @@ -3,7 +3,7 @@ package log | |||
| import ( | |||
| "strings" | |||
|
|
|||
There was a problem hiding this comment.
if we remove this line, then goimports will shuffle this around better
jamietanna
commented
Sep 20, 2023
| @@ -13,9 +13,10 @@ import ( | |||
| "sync/atomic" | |||
| "time" | |||
|
|
|||
There was a problem hiding this comment.
as above, we should drop the newline here, so goimports merges it in better
aymanbagabas
force-pushed
the
slog
branch
2 times, most recently
from
2ae1d55
to
588043a
Compare
|
Thank you @jamietanna. This is now superseded by #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.