Add commit command #331
Merged
Add commit command #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@luandy64 Thanks for the PR, looks good! I think it would be better to match the output of Soft Serve UI commit view to show the commit hash, author, date, stats, and patch. It would also be nice to have a -p option to only show the patch for the commit.
commit 814ee9f8fa7014dd4fafab12974e2edd4b8f7d73
Author: Andy Lu <luandy64@gmail.com>
Date: Fri Jun 30 23:07:49 2023 -0400
Run gofmt
commit 3db029502c74461b57e776a0ebc9d27c944acc5d
Author: Andy Lu <luandy64@gmail.com>
Date: Fri Jun 30 23:06:31 2023 -0400
Pull out statsLine and diffLine, add a commit body line
commit eb1da4296e0181bae842622e0dc98ca8ca845049
Author: Andy Lu <luandy64@gmail.com>
Date: Fri Jun 30 23:05:36 2023 -0400
Add flag for printing the patch only
commit e76702e92b085f02427aae1c7052f235454242fd
Author: Andy Lu <luandy64@gmail.com>
Date: Fri Jun 30 22:50:55 2023 -0400
Add commit, author, date, and stats
commit 0359b1dc49417d11f8f8b8529f8b942417d79128
Author: Andy Lu <luandy64@gmail.com>
Date: Fri Jun 30 21:43:35 2023 -0400
Add commit, author, date, and stats
Missing color on stats
|
Screenshots to go with the last commit (65d308e) No flags: Use Use Use both |
|
Actually, I noticed a whitespace difference in that other commit. So here's one where I compared with the TUI Top of the output: Bottom of the output: |
Codecov Report
@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 47.82% 47.23% -0.59%
==========================================
Files 80 81 +1
Lines 7254 7382 +128
==========================================
+ Hits 3469 3487 +18
- Misses 3512 3622 +110
Partials 273 273
|
aymanbagabas
added a commit
that referenced
this pull request
Jul 17, 2023
* refactor(server): abstract database from backend Prepare for multi database driver support * feat(server): add db models * feat(db): add database migrations * feat(db): add support to postgres * feat: implement database store logic * refactor: use db module and abstract backend logic * fix(db): postgres migrate sql * feat(db): add database query tracing * refactor: move internal packages to server * fix(config): normalize sqlite database path * fix,feat: support custom log path and fix logging leak in hooks * fix(test): race condition * refactor: tidy up files and use middlewares * chore: add test for repo commit command Reference: #331 * fix: lint errors * fix: use utc time and fix git packp error format * fix: lint errors * fix: testscript on windows * chore: format sql files * fix: lint issues re-enable revive linter * refactor: clean up server/config * feat: add admin command to manage server * fix(db): use migration versions * chore: add deprecation warning. * refactor: move shared interfaces and errors to proto * fix: increase golangci lint timeout * feat: add move tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
repo commitcommand that implements #330.QA
Here's the actual text of the command and its output
Screeenshots
With color
Colorless
