Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect gitattributes #342

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix: respect gitattributes #342

merged 2 commits into from
Jul 20, 2023

Conversation

aymanbagabas
Copy link
Member

Check gitattributes for file attrs before displaying files.

Fixes: #238

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #342 (a5a349d) into main (050a0d1) will increase coverage by 0.02%.
The diff coverage is 30.30%.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   50.52%   50.55%   +0.02%     
==========================================
  Files         107      108       +1     
  Lines        8209     8268      +59     
==========================================
+ Hits         4148     4180      +32     
- Misses       3767     3797      +30     
+ Partials      294      291       -3     
Impacted Files Coverage Δ
server/ui/pages/repo/files.go 11.00% <0.00%> (-0.68%) ⬇️
git/attr.go 36.36% <36.36%> (ø)
server/git/service.go 64.13% <100.00%> (+2.95%) ⬆️

... and 4 files with indirect coverage changes

Check gitattributes for file attrs before displaying files.

Fixes: #238
@aymanbagabas aymanbagabas merged commit d0afaa0 into main Jul 20, 2023
@aymanbagabas aymanbagabas deleted the respect-attrs branch July 20, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem rendering age encrypted files
1 participant