Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: job config #402

Merged
merged 4 commits into from
Oct 25, 2023
Merged

feat: job config #402

merged 4 commits into from
Oct 25, 2023

Conversation

jolheiser
Copy link
Contributor

Resolves #361

Initially considered using a map, but this is more explicit which I think is better overall.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jolheiser!

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 2057 lines in your changes are missing coverage. Please review.

Comparison is base (050a0d1) 50.52% compared to head (6d15cb2) 50.40%.
Report is 63 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   50.52%   50.40%   -0.13%     
==========================================
  Files         107      133      +26     
  Lines        8209    11327    +3118     
==========================================
+ Hits         4148     5709    +1561     
- Misses       3767     5178    +1411     
- Partials      294      440     +146     
Files Coverage Δ
git/repo.go 50.69% <ø> (+6.71%) ⬆️
server/backend/backend.go 100.00% <100.00%> (ø)
server/backend/collab.go 86.66% <100.00%> (+0.95%) ⬆️
server/config/config.go 80.66% <100.00%> (+0.66%) ⬆️
server/config/file.go 100.00% <ø> (ø)
server/config/ssh.go 100.00% <100.00%> (ø)
server/cron/cron.go 90.00% <100.00%> (+30.00%) ⬆️
server/db/context.go 85.71% <100.00%> (ø)
server/db/db.go 43.90% <ø> (ø)
server/db/errors.go 31.57% <ø> (ø)
... and 69 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the

README.md Show resolved Hide resolved
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@aymanbagabas aymanbagabas merged commit e2e79fe into charmbracelet:main Oct 25, 2023
9 of 11 checks passed
@jolheiser jolheiser deleted the mirror-config branch October 28, 2023 16:11
aymanbagabas added a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to customize mirroring interval
2 participants