Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using lipgloss tables instead of tablewriter #618

Merged
merged 4 commits into from
Jan 6, 2025
Merged

fix: using lipgloss tables instead of tablewriter #618

merged 4 commits into from
Jan 6, 2025

Conversation

caarlos0
Copy link
Member

closes #617

@caarlos0 caarlos0 mentioned this pull request Dec 16, 2024
Closed
@roccotigger
Copy link

it looks like the tests are failing because they expect no border in the table.
does lipgloss support removing the boarders or does the expected values need to change to match?

roccotigger
roccotigger reviewed Jan 6, 2025
View reviewed changes
Copy link

@roccotigger roccotigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions to have the border be hidden to match the test file expected output

pkg/ssh/cmd/token.go Show resolved Hide resolved
pkg/ssh/cmd/webhooks.go Show resolved Hide resolved
pkg/ssh/cmd/webhooks.go Show resolved Hide resolved
@caarlos0
test: fix
fa91c7a 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0
Copy link
Member Author

caarlos0 commented Jan 6, 2025

suggestions to have the border be hidden to match the test file expected output

i fixed the test... I think it looks better with the borders... 🤔

@caarlos0 caarlos0 merged commit 9cd64aa into main Jan 6, 2025
10 checks passed
@caarlos0 caarlos0 deleted the tables branch January 6, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roccotigger roccotigger roccotigger left review comments

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tablewriter project archived without license
3 participants
@caarlos0 @roccotigger @aymanbagabas