-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add CORS to config, improve test #654
Open
fetsorn
wants to merge
1
commit into
charmbracelet:main
Choose a base branch
from
fetsorn:cors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+83
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetsorn
added a commit
to fetsorn/soft-serve
that referenced
this pull request
Feb 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 51.96% 51.76% -0.20%
==========================================
Files 157 159 +2
Lines 13454 13569 +115
==========================================
+ Hits 6991 7024 +33
- Misses 5891 5973 +82
Partials 572 572 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
53a164e
to
c2b7598
Compare
aymanbagabas
approved these changes
Mar 12, 2025
Thank you for the changes @fetsorn! I will merge once the tests pass |
I also added several allowed headers needed for preflight requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for #516, I've corrected the test case and added CORS to the default config.