Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lipgloss padding is rendered incorrectly #282

Closed
StarpTech opened this issue Apr 10, 2023 · 5 comments
Closed

lipgloss padding is rendered incorrectly #282

StarpTech opened this issue Apr 10, 2023 · 5 comments

Comments

@StarpTech
Copy link

StarpTech commented Apr 10, 2023

See "SUCCESS" label works absolutely fine in terminals.

PassStyle = lipgloss.NewStyle().Bold(true).Foreground(lipgloss.Color("#ffffff")).Background(lipgloss.Color("#5AD900")).Padding(0, 1)
doc.WriteString(fmt.Sprintf("%s %s\n", PassStyle.Render("SUCCESS"), m.internalTask.Name))

demo

@maaslalani
Copy link
Contributor

Hey @StarpTech. Thanks for opening up this issue. It's related to: #249. It will be fixed once xterm.js 5.2.0 is released.

@maaslalani
Copy link
Contributor

Hey there, this should be fixed now if you use vhs@main:

go install github.com/charmbracelet/vhs@main

and ttyd@main:

brew install ttyd --HEAD

Feel free to reopen this issue if it's not solved for you after updating both dependencies ^

@rbergmanaf
Copy link

rbergmanaf commented May 16, 2023

We are using vhs in Docker and are seeing this issue with ttyd 1.7.3. When we use the ttyd:alpine image (which features the xtermjs update on ttyd main), none of the keyboard input from our tape files ends up making it into the rendered gif/mp4/txt/etc -- the output just features a prompt and blinking cursor.

I can seek more information if needed, but that's all I have at the moment. Very much looking forward to the fix described in xtermjs 5.2.0, but for now we had to revert our Dockerfile to pull from the ttyd 1.7.3 release to keep vhs working.

@maaslalani
Copy link
Contributor

@rbergmanaf Are you using the latest commit in VHS, ttyd 1.7.3 recently changed the terminal to be read only by default which is fixed in a recent commit in VHS: 22854ac

@rbergmanaf
Copy link

Oh my, that was the problem! Sorry I missed that. Thanks for the great tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants