Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: put pty slave in raw mode before querying #351

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: put pty slave in raw mode before querying #351

merged 1 commit into from
Oct 29, 2024

Conversation

caarlos0
Copy link
Member

fixes #350

@caarlos0 caarlos0 added the bug Something isn't working label Oct 28, 2024
@caarlos0 caarlos0 self-assigned this Oct 28, 2024
aymanbagabas
aymanbagabas approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we will no longer need this with Bubble Tea v2 and Lip Gloss v2

@caarlos0 caarlos0 merged commit 85d7557 into main Oct 29, 2024
12 checks passed
@caarlos0 caarlos0 deleted the fix-raw-pty branch October 29, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees

@caarlos0 caarlos0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

background color queries are being printed out
2 participants
@caarlos0 @aymanbagabas