Charmhub/address charmhub limitiations #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
addyess
commented
Feb 4, 2022
addyess
commented
- improve API used to fetch charmhub info
- handle bundle resource revisions to override the charm default revision on non-snap based resources
….priv in lxd, and made 'bundles' a required argument
… into charmhub/address-charmhub-limitiations
…ources from charmhub
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 85.63% 86.54% +0.90%
==========================================
Files 1 1
Lines 362 379 +17
==========================================
+ Hits 310 328 +18
+ Misses 52 51 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… into charmhub/address-charmhub-limitiations
addyess
force-pushed
the
charmhub/address-charmhub-limitiations
branch
4 times, most recently
from
ca54c4b
to
2145632
Compare
|
Addresses #10 as well |
addyess
force-pushed
the
charmhub/address-charmhub-limitiations
branch
from
2145632
to
4a7c388
Compare
kwmonroe
approved these changes
Feb 7, 2022
| @@ -332,9 +326,38 @@ def download(self): | |||
| check_call(shlx(f"mv {tgz} {snap_target}")) | |||
|
|
|||
|
|
|||
| class ResourceDownloader(Downloader): | |||
| URL = "https://api.jujucharms.com/charmstore/v5" | |||
| class Resource(namedtuple("Resource", "name, type, path, revision, url_format")): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.