Improve exception tracing when setting up a k8s-cloud #1404
Conversation
| clouds = await tools.run( | ||
| "juju", "clouds", "--format", "yaml", "-c", tools.controller_name | ||
| ) | ||
| if tools.k8s_cloud in yaml.safe_load(clouds[0]): | ||
| yield tools.k8s_cloud | ||
| return |
There was a problem hiding this comment.
first -- let's see if the cloud we want already exists -- to prevent a failure when adding it a second time
| await tools.run( | ||
| "juju", | ||
| "add-k8s", | ||
| "--skip-storage", | ||
| "-c", | ||
| tools.controller_name, | ||
| tools.connection, | ||
| proxy=tools.juju_ssh_proxy, | ||
| tools.k8s_cloud, | ||
| ) |
There was a problem hiding this comment.
next, let's add-k8s. The kubeconfig fixture will handle adding the correct kubeconfig file into the os.environment
addyess
force-pushed
the
akd/validation/error-propigation-setting-up-k8s-cloud
branch
from
4cdc739
to
967750b
Compare
| if _created: | ||
| click.echo("Removing k8s cloud") |
There was a problem hiding this comment.
the remove portion is only run if _created was set
We're careful not to return during the finally so as to not lose any exceptions that may still need to bubble out
| click.echo("Cleaning up k8s model") | ||
| try: | ||
| for relation in k8s_model.relations: | ||
| if _model_created: |
There was a problem hiding this comment.
we're careful here to not return in the finally, so exceptions can freely bubble out
| return | ||
| await tools.run("juju-crashdump", "-a", "config", "-m", tools.k8s_connection) | ||
| click.echo("Cleaning up k8s model") | ||
| try: |
There was a problem hiding this comment.
also -- stop trying to catch errors in the finally -- just let the exceptions flow so we can find the issues
| path = Path.home() / ".local/share/juju" | ||
| with NamedTemporaryFile(dir=path) as f: |
There was a problem hiding this comment.
because juju is a strictly confined snap, there are use cases where this temporary file really should be in a path that juju can read it. That's really only under $HOME/.local/share/juju
so it's a temporary file in here
let's add it to the os.environ for things like kubectl or juju to be able to use naturally without have to feed its filename into the env
kwmonroe
deleted the
akd/validation/error-propigation-setting-up-k8s-cloud
branch
We continue to see errors in the validation tests where
k8s_cloudfixture is involved, but the only error coming back has to do with a failed async. This is because the fixture is trying too hard to catch exceptions -- when it should really bubble those outThere's also a bit of flakiness in many tests to get the
kubeconfigfrom the control-plane unit. lets setup one fixture that can do that for every test. If we don't like it being module scoped -- that's fine we can remove that.