Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update canal with recent improvements to flannel #77

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

kwmonroe
Copy link
Contributor

@kwmonroe kwmonroe commented Feb 9, 2023

This aligns the flannel portion of canal with the recent fixes for lp2004150:

  • align gh workflow and tox with the current charm-flannel impl
  • use etcd3 calls to align with charm-flannel changes
  • follow ck best practices for integration tests (overlay k8s-core with locally built charm/resources)
  • use the word align as much as possible in this PR description

.github/workflows/tox.yaml Outdated Show resolved Hide resolved
Copy link
Member

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kwmonroe these changes look perfect. A really nice upgrade

- dupe recent charm-flannel improvements for building resources
- drop crashdump in favor of a simple debug-log for failed runner jobs
- bump resource script to known-good charm-flannel commit
- tox tweaks to be consistent with other charms
passenv =
http_proxy
https_proxy
no_proxy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox4 didn't like these on the same line, but newlines are compatible with both tox3 and 4.

@kwmonroe kwmonroe marked this pull request as ready for review February 9, 2023 20:22
@kwmonroe kwmonroe merged commit ab082ac into main Feb 9, 2023
@kwmonroe kwmonroe deleted the lp2004150-update-flannel branch February 9, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants