Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add juju max-frame-size option #145

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

addyess
Copy link
Member

@addyess addyess commented Dec 6, 2024

Addresses #144

Adds --juju-max-frame-size pytest option to change the connection size when connecting to juju models.

Details

  • switched to ruff for format and linting
  • improved unit tests to test max-frame-size

@addyess addyess force-pushed the issue/144/juju-max-frame-size branch 3 times, most recently from 12ee2ec to f31886e Compare December 6, 2024 05:29
@addyess
Copy link
Member Author

addyess commented Dec 6, 2024

@dimaqq look right to you?

@addyess addyess force-pushed the issue/144/juju-max-frame-size branch from f31886e to 4a3fb1b Compare December 6, 2024 05:38
docs/reference.md Outdated Show resolved Hide resolved
pytest_operator/plugin.py Outdated Show resolved Hide resolved
@dimaqq
Copy link
Contributor

dimaqq commented Dec 6, 2024

Related change juju/python-libjuju#1239

This change may still be worth it for folks who have to use older python-libjuju

@addyess addyess force-pushed the issue/144/juju-max-frame-size branch from c8c9fa9 to 9342027 Compare December 6, 2024 13:42
tox.ini Outdated Show resolved Hide resolved
@addyess addyess merged commit fd454cd into main Dec 6, 2024
14 checks passed
@addyess addyess deleted the issue/144/juju-max-frame-size branch December 6, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants