ssh wrapper for PROBE #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be easier to test this with an OpenSSH docker image. But then you have to do at least two steps: one to upload the keys and one to test. Read their README carefully. It's up to you. Please document whatever route you choose. |
charmoniumQ
reviewed
Jun 20, 2024
|
This implementation looks reasonable; let me know when you can run tests. |
charmoniumQ
reviewed
Jul 9, 2024
charmoniumQ
reviewed
Jul 10, 2024
Shofiya2003
reviewed
Aug 5, 2024
charmoniumQ
reviewed
Aug 8, 2024
charmoniumQ
reviewed
Aug 14, 2024
charmoniumQ
reviewed
Aug 14, 2024
Merged
charmoniumQ
reviewed
Sep 13, 2024
|
For the Docker, you would need to generate the rsa key pair in order for the ssh wrapper to work |
charmoniumQ
approved these changes
Sep 18, 2024
charmoniumQ
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script was tested using openssh docker image.
You can run the script by:
env__PROBE_LIB=libprobe/build python -m probe_py.manual.cli ssh -- [ssh_args] <remote@host> [remote_cmd]