Fixed syncronization bug with file-backed memory. #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code calls
munmap()
without first invokingmsync()
on the same region: as explained in msync(2), this is a synchronization bug:This PR breaks out arena unmapping into an inline static function that first calls
msync()
with theMS_SYNC
flag which requests a page sync for the mapped region and blocks until synchronization is complete, then unmaps the pages withmunmap()
.