-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CPU topology initialization (Fixes subsequent hang in CmiBarrier) #2838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hang can be observed with comm thread builds (e.g. UCX), with a |
minitu
changed the title
Fix CmiBarrier hang after CPU topology init
Update CPU Topology Initialization (Fixes subsequent hang in CmiBarrier)
May 28, 2020
minitu
changed the title
Update CPU Topology Initialization (Fixes subsequent hang in CmiBarrier)
Update CPU topology initialization (Fixes subsequent hang in CmiBarrier)
May 28, 2020
… after CPU topology init
Removing from 6.11 for now, as it is unclear how this should be fixed. |
Closing, will reopen or create a new PR once we figure out how to solve the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hang could be observed when
CmiBarrier
is used afterCmiInitCPUTopology
in_initCharm
(src/ck-core/init.C
). This issue was caused by comm threads prematurely exiting theCmiNetworkProgress
loop (lines 485-490) and thus failing to pass theCmiReduce
message (line 538) to PE 0.I believe the original code seemed to work fine (when
CmiBarrier
was not used) because at some later point in time the comm threads would have resumed processing their message queues, including the remainingCmiReduce
messages.This PR modifies the CPU topology init process (how messages are passed, in particular), by referring to the CPU affinity init code which did not exhibit issues with subsequent
CmiBarrier
calls.