-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up cputopology initialization global communication pattern #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
evan-charmworks
commented
Aug 12, 2021
•
edited
Loading
edited
- Replaces error-prone locking and improper scheduler driving with well-tested pattern from Isomalloc-Sync
- Replaces bespoke "empty reduction" with CmiBarrier
- Replaces Broadcast with NodeBroadcast and moves send outside of handler
- Replaces unnecessary privatization of Converse handler index variables with CmiAssignOnce
evan-charmworks
requested review from
rbuch,
matthiasdiener,
epmikida,
ericjbohm,
jszaday,
minitu,
stwhite91,
PathikritGhosh,
nitbhat,
slm960323,
ZwFink and
trquinn
August 12, 2021 18:41
|
ericjbohm
previously approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit comment should note motive for switching from locked Cpv to atomic.
Updated. |
matthiasdiener
approved these changes
Aug 14, 2021
Needs one more review. |
ericjbohm
approved these changes
Aug 16, 2021
evan-charmworks
added a commit
that referenced
this pull request
Aug 19, 2021
- Replaces error-prone locking and improper scheduler driving with well-tested pattern from Isomalloc-Sync - Replaces bespoke "empty reduction" with CmiBarrier - Replaces Broadcast with NodeBroadcast and moves send outside of handler - Replaces unnecessary privatization of Converse handler index variables with CmiAssignOnce
evan-charmworks
added a commit
that referenced
this pull request
Aug 19, 2021
- Replaces error-prone locking and improper scheduler driving with well-tested pattern from Isomalloc-Sync - Replaces bespoke "empty reduction" with CmiBarrier - Replaces Broadcast with NodeBroadcast and moves send outside of handler - Replaces unnecessary privatization of Converse handler index variables with CmiAssignOnce
stwhite91
pushed a commit
that referenced
this pull request
May 11, 2023
- Replaces error-prone locking and improper scheduler driving with well-tested pattern from Isomalloc-Sync - Replaces bespoke "empty reduction" with CmiBarrier - Replaces Broadcast with NodeBroadcast and moves send outside of handler - Replaces unnecessary privatization of Converse handler index variables with CmiAssignOnce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.