Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update similarity module #256

Merged
merged 9 commits into from
Jul 1, 2019
Merged

Update similarity module #256

merged 9 commits into from
Jul 1, 2019

Conversation

bdewilde
Copy link
Collaborator

@bdewilde bdewilde commented Jul 1, 2019

Description

  • add character ngram-based similarity measure, for something that's useful in different contexts than the other measures
  • remove jaro-winkler string similarity measure, since it was just a wrapper around the underlying implementation and didn't add much beyond other measures
  • make token sort ratio faster
  • replace python-levenshtein dependency with jellyfish, for its active development, better documentation, and compliant license
  • improve tests and tidy up docs

Motivation and Context

The incompatible license issue has been an outstanding to-do for a long time. Otherwise, just the usual house-cleaning. :)

How Has This Been Tested?

Refactored existing tests, wrote a few new ones, and all are passing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation, and I have updated it accordingly.

bdewilde added 9 commits June 28, 2019 20:50
jellyfish is actively maintained, has better documentation, and has a license that's actually compatible with textacy's
It's hard to tell, bc python-levenshtein isn't well documented, but it looks like I'm normalizing absolute Levenshtein edit distance differently. However, I _think_ their code has been wrong all this time?
just use jellyfish directly, if needed
@bdewilde bdewilde marked this pull request as ready for review July 1, 2019 02:01
@bdewilde bdewilde merged commit 6426054 into develop Jul 1, 2019
@bdewilde bdewilde deleted the update-similarity-module branch July 1, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant