Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize and streamline python packaging #347

Merged
merged 9 commits into from
Nov 14, 2021
Merged

Conversation

bdewilde
Copy link
Collaborator

@bdewilde bdewilde commented Nov 14, 2021

Description

  • removes setuptools-based package builds in favor of build
  • moves mypy configuration into pyproject.toml
  • extends and tidies up repo Makefile
  • fixes and streamlines installs during github workflows

Motivation and Context

Python's packaging tooling and recommendations continue to evolve: setuptools has gotten out of the building business, pyproject.toml has added more supported tools, and a couple of PEPs got approved. These changes bring textacy into line with modern but not-too-fancy packaging.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation, and I have updated it accordingly.

@bdewilde bdewilde changed the base branch from main to develop November 14, 2021 18:04
@bdewilde bdewilde force-pushed the update-python-packaging branch from 5cdb172 to f31fce8 Compare November 14, 2021 18:48
@bdewilde bdewilde marked this pull request as ready for review November 14, 2021 18:54
@bdewilde bdewilde merged commit 524b0aa into develop Nov 14, 2021
@bdewilde bdewilde deleted the update-python-packaging branch November 14, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant