Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type hints to PY39 (and fix various errors and mypy nonsense) #372

Merged
merged 4 commits into from
Mar 18, 2023

Conversation

bdewilde
Copy link
Collaborator

@bdewilde bdewilde commented Mar 18, 2023

Description

  • updates tons of type hints to use py3.9's generic built-ins
  • adds many type annotations so mypy can figure out what's actually going on
  • fixes various type hint mistakes / mypy bugaboos, so mypy will complain less

Motivation and Context

ideally would like to get down to zero mypy errors then turn on those type checks for real in CI, but this will have to do -- from ~250 mpy errors to ~40

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation, and I have updated it accordingly.

@bdewilde bdewilde marked this pull request as ready for review March 18, 2023 16:10
@bdewilde bdewilde merged commit 0ab02fa into develop Mar 18, 2023
@bdewilde bdewilde deleted the update-type-hints-py39 branch March 18, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant