Richtexteditor formats #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbessou
force-pushed
the
richtexteditor-formats
branch
from
6e3df23
to
e781bdb
Compare
Paragraph symbols were catching clicks.
When inline-block, a second cursor `slot` is created after the note node.
By not relying on regexps and by using DOM queries instead.
There is code duplication between this and DocumentNotes.
Otherwise titles containing fa icons are not rendered.
…ify keyboard navigation
There is a lot of stuff in there.
Main changes:
RichTextEditor is now initialized with its initial value props. After
that, it is not controlled and only sends its new value to its parent
component in the hierarchy.
NoteForm is updated so that the first time it is rendered, the
RichTextEditor value props is already defined. Before this change, the
editor was populated on second render, after the call to the mounted
lifecycle hook.
Components that take input data as propse now expect a single data
structure as prop. For example, NoteForm `inputData` prop could be
either {note: {id: number}} or {formats: {note: {id: number}}, leading
to big conditionals.
A lot of imperative logic is transformed into more functional logic by
using computed component state. This is the case for example for the
way the "activeness" of the buttons is computed. We remove the
`updateButtons` method from the RichTextEditor and instead compute the
buttons availability from the component's current state on render.
Notes and Page breaks are transformed into embeds to avoid hard to
maintain logic to ensure that their inner text are not modified.
This allow us to write specific keyboard and mouse handlers for these
elements the embeds are selected on click ot when navigating over them
with keyboard.
A new `remove format` button is added in the RichTextEditor which allows
to ensure that the text going to be typed will not be formatted. A new
icon should be chosen for this button as it is currently the same as
"stroked text"/"del" button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #140.