Fix line / non-numeric-y (#6617)

chartjs · Oct 27, 2019 · 0de668b · 0de668b
1 parent d4dc505
commit 0de668b
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 1 deletion.
diff --git a/src/controllers/controller.line.js b/src/controllers/controller.line.js
@@ -209,8 +209,9 @@ module.exports = DatasetController.extend({
 			if (rightValue < 0) {
 				return yScale.getPixelForValue(sumNeg + rightValue);
 			}
+			return yScale.getPixelForValue(sumPos + rightValue);
 		}
-		return yScale.getPixelForValue(sumPos + rightValue);
+		return yScale.getPixelForValue(value);
 	},
 
 	updateBezierControlPoints: function() {

diff --git a/test/fixtures/controller.line/non-numeric-y.json b/test/fixtures/controller.line/non-numeric-y.json
@@ -0,0 +1,34 @@
+{
+    "config": {
+        "type": "line",
+        "data": {
+            "xLabels": ["January", "February", "March", "April", "May", "June", "July"],
+            "yLabels": ["", "Request Added", "Request Viewed", "Request Accepted", "Request Solved", "Solving Confirmed"],
+            "datasets": [{
+                "label": "My First dataset",
+                "data": ["", "Request Added", "Request Added", "Request Added", "Request Viewed", "Request Viewed", "Request Viewed"],
+                "fill": false,
+                "borderColor": "red",
+                "backgroundColor": "red"
+            }]
+        },
+        "options": {
+            "responsive": false,
+            "legend": false,
+            "title": false,
+            "scales": {
+                "xAxes": [{"display": false}],
+                "yAxes": [{
+                    "type": "category",
+                    "display": false
+                }]
+            }
+        }
+    },
+    "options": {
+        "canvas": {
+            "height": 256,
+            "width": 512
+        }
+    }
+}
diff --git a/test/fixtures/controller.line/non-numeric-y.png b/test/fixtures/controller.line/non-numeric-y.png