Skip to content

Commit

Permalink
Re-parse existing elements when data is replaced (#6925)
Browse files Browse the repository at this point in the history
* Re-parse existing elements when data is replaced
* Update test
  • Loading branch information
kurkle authored and etimberg committed Jan 10, 2020
1 parent d4109ca commit 5054ecf
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/core/core.datasetController.js
Original file line number Diff line number Diff line change
Expand Up @@ -1051,6 +1051,10 @@ helpers.extend(DatasetController.prototype, {

if (numData > numMeta) {
me.insertElements(numMeta, numData - numMeta);
if (changed && numMeta) {
// insertElements parses the new elements. The old ones might need parsing too.
me._parse(0, numMeta);
}
} else if (numData < numMeta) {
meta.data.splice(numData, numMeta - numData);
meta._parsed.splice(numData, numMeta - numData);
Expand Down
10 changes: 9 additions & 1 deletion test/specs/core.datasetController.tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -299,14 +299,22 @@ describe('Chart.DatasetController', function() {
var meta = chart.getDatasetMeta(0);

expect(meta.data.length).toBe(6);
expect(meta._parsed.map(p => p.y)).toEqual(data0);

chart.data.datasets[0].data = data1;
chart.update();

expect(meta.data.length).toBe(3);
expect(meta._parsed.map(p => p.y)).toEqual(data1);

data1.push(9);
expect(meta.data.length).toBe(4);

chart.data.datasets[0].data = data0;
chart.update();

data1.push(9, 10, 11);
expect(meta.data.length).toBe(6);
expect(meta._parsed.map(p => p.y)).toEqual(data0);
});

it('should re-synchronize metadata when data are unusually altered', function() {
Expand Down

0 comments on commit 5054ecf

Please sign in to comment.