3.8.1 build breaks

[mmarton]

Expected behavior

no error happens

Current behavior

Not sure what is the issue here, my build works with 3.8.0 and breaks with 3.8.1 so some breaking change has been introduced.
The messages come from 3rd party libs

Module build failed: Module not found:
"./node_modules/@symfony/stimulus-bridge/lazy-controller-loader.js!./assets/controllers/chart/optimus_chart_controller.js" contains a reference to the file "chart.js/auto".
This file can not be found, please check it for typos or update it if the file got moved.

"./node_modules/@symfony/ux-chartjs/dist/controller.js" contains a reference to the file "chart.js/auto".
This file can not be found, please check it for typos or update it if the file got moved.

"./node_modules/chartjs-plugin-datalabels/dist/chartjs-plugin-datalabels.esm.js" contains a reference to the file "chart.js/helpers".
This file can not be found, please check it for typos or update it if the file got moved.

Reproducible sample

I will try to make a simple reproducer

Optional extra steps/info to reproduce

No response

Possible solution

No response

Context

No response

chart.js version

3.8.1

Browser name and version

firefox 100

Link to your project

No response

[elhay-avihezer]

The issue is

not found: Error: Can't resolve 'chart.js/auto'

This code is working in v3.8.0

import 'chart.js/auto';

but in v3.8.1 it throw an error in build time Can't resolve 'chart.js/auto'

This is a breaking change in patch version, i didn't found the relevant PR/commit that cause this error.

[etimberg]

This was not intentional. It appears to be caused by https://github.com/chartjs/Chart.js/blob/master/auto/package.json not making it to NPM. It's unclear why this happened since we haven't changed anything related to how the publish works

[elhay-avihezer]

Thank you,
I think that the best practice here, is to revert this change and push it in a new major version to prevent from build from failures.

[etimberg]

The problem seems to be caused by upgrading from node v14 and npm v6 to node v16 and npm 8. NPM 8 is not detecting the subpackage package.json files whereas npm 6 did.

NPM 8

> npm publish --dry-run
npm notice
npm notice 📦  chart.js@3.8.1
npm notice === Tarball Contents ===
npm notice 1.1kB   LICENSE.md
npm notice 2.6kB   README.md
npm notice 103B    auto/auto.esm.d.ts
npm notice 117B    auto/auto.esm.js
npm notice 43B     auto/auto.js
npm notice 339.7kB dist/chart.esm.js
npm notice 413.5kB dist/chart.js
npm notice 197.3kB dist/chart.min.js
npm notice 74.7kB  dist/chunks/helpers.segment.js
npm notice 2.5kB   dist/helpers.esm.js
npm notice 3.9kB   dist/uPlot.js
npm notice 303B    dist/worker.js
npm notice 34B     helpers/helpers.esm.d.ts
npm notice 37B     helpers/helpers.esm.js
npm notice 40B     helpers/helpers.js
npm notice 4.1kB   package.json
npm notice 2.5kB   types/adapters.d.ts
npm notice 950B    types/animation.d.ts
npm notice 99B     types/basic.d.ts
npm notice 61B     types/color.d.ts
npm notice 493B    types/element.d.ts
npm notice 558B    types/geometric.d.ts
npm notice 2.7kB   types/helpers/helpers.canvas.d.ts
npm notice 857B    types/helpers/helpers.collection.d.ts
npm notice 1.2kB   types/helpers/helpers.color.d.ts
npm notice 6.4kB   types/helpers/helpers.core.d.ts
npm notice 992B    types/helpers/helpers.curve.d.ts
npm notice 779B    types/helpers/helpers.dom.d.ts
npm notice 187B    types/helpers/helpers.easing.d.ts
npm notice 809B    types/helpers/helpers.extras.d.ts
npm notice 11B     types/helpers/helpers.interpolation.d.ts
npm notice 313B    types/helpers/helpers.intl.d.ts
npm notice 767B    types/helpers/helpers.math.d.ts
npm notice 2.6kB   types/helpers/helpers.options.d.ts
npm notice 553B    types/helpers/helpers.rtl.d.ts
npm notice 11B     types/helpers/helpers.segment.d.ts
npm notice 509B    types/helpers/index.d.ts
npm notice 113.5kB types/index.esm.d.ts
npm notice 1.6kB   types/layout.d.ts
npm notice 818B    types/utils.d.ts
npm notice === Tarball Details ===
npm notice name:          chart.js
npm notice version:       3.8.1
npm notice filename:      chart.js-3.8.1.tgz
npm notice package size:  292.8 kB
npm notice unpacked size: 1.2 MB
npm notice shasum:        7fa1cb60ddada773927ec12c4b3accb9a198214e
npm notice integrity:     sha512-cXgl0uEtq0hOr[...]rIB2Ru0/hlhPQ==
npm notice total files:   40
npm notice
+ chart.js@3.8.1

NPM 6

❯ npm --version
6.14.17
❯ npm publish --dry-run
npm notice
npm notice 📦  chart.js@3.8.1
npm notice === Tarball Contents ===
npm notice 117B    auto/auto.esm.js
npm notice 43B     auto/auto.js
npm notice 339.7kB dist/chart.esm.js
npm notice 413.5kB dist/chart.js
npm notice 197.3kB dist/chart.min.js
npm notice 2.5kB   dist/helpers.esm.js
npm notice 37B     helpers/helpers.esm.js
npm notice 40B     helpers/helpers.js
npm notice 74.7kB  dist/chunks/helpers.segment.js
npm notice 3.9kB   dist/uPlot.js
npm notice 303B    dist/worker.js
npm notice 182B    auto/package.json
npm notice 183B    helpers/package.json
npm notice 4.1kB   package.json
npm notice 1.1kB   LICENSE.md
npm notice 2.6kB   README.md
npm notice 2.5kB   types/adapters.d.ts
npm notice 950B    types/animation.d.ts
npm notice 103B    auto/auto.esm.d.ts
npm notice 99B     types/basic.d.ts
npm notice 61B     types/color.d.ts
npm notice 493B    types/element.d.ts
npm notice 558B    types/geometric.d.ts
npm notice 2.7kB   types/helpers/helpers.canvas.d.ts
npm notice 857B    types/helpers/helpers.collection.d.ts
npm notice 1.2kB   types/helpers/helpers.color.d.ts
npm notice 6.4kB   types/helpers/helpers.core.d.ts
npm notice 992B    types/helpers/helpers.curve.d.ts
npm notice 779B    types/helpers/helpers.dom.d.ts
npm notice 187B    types/helpers/helpers.easing.d.ts
npm notice 34B     helpers/helpers.esm.d.ts
npm notice 809B    types/helpers/helpers.extras.d.ts
npm notice 11B     types/helpers/helpers.interpolation.d.ts
npm notice 313B    types/helpers/helpers.intl.d.ts
npm notice 767B    types/helpers/helpers.math.d.ts
npm notice 2.6kB   types/helpers/helpers.options.d.ts
npm notice 553B    types/helpers/helpers.rtl.d.ts
npm notice 11B     types/helpers/helpers.segment.d.ts
npm notice 509B    types/helpers/index.d.ts
npm notice 113.5kB types/index.esm.d.ts
npm notice 1.6kB   types/layout.d.ts
npm notice 818B    types/utils.d.ts
npm notice === Tarball Details ===
npm notice name:          chart.js
npm notice version:       3.8.1
npm notice package size:  294.7 kB
npm notice unpacked size: 1.2 MB
npm notice shasum:        544cc19ca961d6d876dc958d0d1030e6ee710384
npm notice integrity:     sha512-0zaQhBgqLZrSn[...]xXS3JHE6HI9GQ==
npm notice total files:   42
npm notice
+ chart.js@3.8.1

[etimberg]

This is hopefully fixed in 3.8.2