Chart data type is incorrect in 4.1.2

[tleunen]

Expected behavior

The types for the Chart object has data: ChartData, but it should be data: ChartData<TType, TData, TLabel>; instead to have the dataset typed properly within the data. Otherwise it's the default types from DefaultDataPoint<TType>

export declare class Chart<
  TType extends ChartType = ChartType,
  TData = DefaultDataPoint<TType>,
  TLabel = unknown
> {
 // ...
  data: ChartData<TType, TData, TLabel>;
 // ...

Current behavior

export declare class Chart<
  TType extends ChartType = ChartType,
  TData = DefaultDataPoint<TType>,
  TLabel = unknown
> {
 // ...
  data: ChartData;
 // ...

Reproducible sample

https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgYQBYENZwL5wGZQQhwDkAxhrAHQBWAziQNwCwAUGzAJ5gCmK6MHgHNonAGroANgFc+AXkRs4cMgOGiAXHDowowAHZCWrZQDcpsrfukgARjyjHlZCJOgB+LTr2Hj2NhzcfGiYMAAqQXAKIbAAPABEkgY88QA0-IIiUOIWPADaALoAfAGsAPRlcAByEDDAZHxhqHwAIgLoEbxwACYQPHT6JPAYpnwwzXBcvHRwYISmwN083fiExDHhQYFdbTAdkdGUm7x5JN3tJAWMQA

Optional extra steps/info to reproduce

No response

Possible solution

No response

Context

No response

chart.js version

4.1.2

Browser name and version

No response

Link to your project

No response

[LeeLenaleee]

Happend in #10963

[dangreen]

@tleunen Hi. It's not a bug, it is expected behavior. You should be able to change data in runtime. Please see the PR description that @LeeLenaleee mentioned.

[LeeLenaleee]

To be honest I think that this behaviour is more unwanted as the binding of the chart instance 🤔

[LeeLenaleee]

Also another issue got posted about this (see above linked issue), in my oppinion it would be better to revert the changes and see if we can solve it another way because this way of working seems way more likely to me as having a runtime change and the downside of dealing with that

[elPandaFriki]

I've returned to version 4.0.1 until a solution has been decided.

[LeeLenaleee]

@etimberg @kurkle what are your oppinions about this?

[etimberg]

A revert probably makes sense unless we can find a way to fix it. @dangreen thoughts?

[dangreen]

@etimberg I've made the PR