fix: unbind instance config from chart type #10963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LeeLenaleee @etimberg @kurkle review please 🙏 |
kurkle
approved these changes
Dec 15, 2022
|
I'm probably not considering the full impact of this, but then again if it passes tests, it should be ok. |
etimberg
approved these changes
Dec 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10865
Chart and datasets types can be changed in runtime, but types restrict it. In this PR, I unbound the instance's config from the initial chart type.
Here is an example: https://stackblitz.com/edit/typescript-7g6pc8?file=index.ts
The code works, but TS prints errors.