-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Candlestick graph type #3540
Comments
@tracerstevens there isn't one in the core. I think this is a good opportunity for a chart type that could live in an external repository since it's more specific |
Sounds good, if I wanted to give it a try, what files would I generally be touching? |
@tracerstevens you're probably going to want to start with the controllers: https://github.com/chartjs/Chart.js/tree/master/src/controllers You'd need a controller for the new chart type. You'd also probably want a new element since the basic rectangle one won't do: https://github.com/chartjs/Chart.js/tree/master/src/elements |
Closing since we will not ship this type of chart in the core. The best solution is to create a new chart type for this. |
Any progress on a candle chart? (even if not core) |
I'm also curious if there is any news about this. |
Same here, I am really interested in his kind of chart. Anyone who has done it or should i try myself? |
In my experience candlestick charts are very popular and widely supported, and not at all niche or specific. I did a survey of a dozen other JS charting libraries as seen below and candlestick charts seemed to be very popular. Additionally, candlestick charts are supported in all major spreadsheet programs such as Excel, Google Spreadsheets, and LibreOffice.
I understand that chartjs wants to support only very core charts and doesn't want to open the flood gates to every random and super specific request that comes in. At the same time, I think candlestick charts are so common that it may make sense to consider supporting in some manner. I'd like to see a pathway for such a common chart to make it into the core project perhaps starting as an external chart. In the meantime, is there some other way for a candlestick plugin to become officially recognized such as living under the chartjs organization? |
@benmccann we're happy to have someone write and maintain a candlestick plugin that could live in the chartjs organization. I would say that the best way to get started on something like that would be to create the chart and get it working well, then we can find a way to transfer the repository into the organization. |
Thanks @etimberg ! |
We have a candlestick chart now: https://github.com/chartjs/chartjs-chart-financial Feedback welcome |
@benmccann great, thanks! I'm kinda new to chart.js, how do I install it? TIA |
I'm working on some improvements and cleanup still before the initial release. For now you would have to build it yourself |
how to build it ourselves? |
@benmccann Thanks for the work you've done so far on adding the financial / candle plugin. You mention that there's improvements/cleanup to take place before initial release. I peeked at the open issue list and didn't see anything by you. If you find the time to expand upon what needs to be accomplished for it to be taken to production, I might have the time to dig into some of it in the future. I've an interest in using the plugin and have decent experience working with the main library / contributing to OSS. |
@MeoMix there's a description of the time scale cleanup (which is in progress) on the README: https://github.com/chartjs/chartjs-chart-financial |
@benmccann Great, thanks. Sorry for missing that! |
Looking forward to having candlesticks. Please don't let it evaporate. |
me to! |
+1 for that |
We're just about to release 2.7.1 which has an additional set of time scale improvements and bug fixes to further improve the candlestick rendering There's still some more work that I'm doing on the chart in 2.8.0. E.g. right now the tooltips don't work on the time scale. I'm trying to fix that in #4583 |
Looking forward to having candlesticks for me too! cant wait! |
Still no Candlestick implementation! What are you lazy assholes doing!? |
@benmccann, are you planning to include candlestick chart into Chart.js core? |
No, I'm not currently planning to include it in core. While I'd be happy to do so, I'm not sure that the change would be accepted as Chart.js aims to keep the core as small as possible and implement most features as external plugins. For now, I would recommend using https://github.com/chartjs/chartjs-chart-financial |
Has anyone considered contributing a candlestick graph type?
The text was updated successfully, but these errors were encountered: