Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candlestick graph type #3540

Closed
tracerstevens opened this issue Nov 2, 2016 · 26 comments
Closed

Candlestick graph type #3540

tracerstevens opened this issue Nov 2, 2016 · 26 comments

Comments

@tracerstevens
Copy link

Has anyone considered contributing a candlestick graph type?

@etimberg
Copy link
Member

etimberg commented Nov 2, 2016

@tracerstevens there isn't one in the core. I think this is a good opportunity for a chart type that could live in an external repository since it's more specific

@tracerstevens
Copy link
Author

Sounds good, if I wanted to give it a try, what files would I generally be touching?

@etimberg
Copy link
Member

etimberg commented Nov 2, 2016

@tracerstevens you're probably going to want to start with the controllers: https://github.com/chartjs/Chart.js/tree/master/src/controllers

You'd need a controller for the new chart type. You'd also probably want a new element since the basic rectangle one won't do: https://github.com/chartjs/Chart.js/tree/master/src/elements

@etimberg
Copy link
Member

etimberg commented Jan 7, 2017

Closing since we will not ship this type of chart in the core. The best solution is to create a new chart type for this.

@etimberg etimberg closed this as completed Jan 7, 2017
@ajp8164
Copy link

ajp8164 commented Jan 19, 2017

Any progress on a candle chart? (even if not core)

@KoalaBear84
Copy link

I'm also curious if there is any news about this.

@mce1978
Copy link

mce1978 commented Apr 10, 2017

Same here, I am really interested in his kind of chart. Anyone who has done it or should i try myself?

@benmccann
Copy link
Contributor

In my experience candlestick charts are very popular and widely supported, and not at all niche or specific. I did a survey of a dozen other JS charting libraries as seen below and candlestick charts seemed to be very popular. Additionally, candlestick charts are supported in all major spreadsheet programs such as Excel, Google Spreadsheets, and LibreOffice.

I understand that chartjs wants to support only very core charts and doesn't want to open the flood gates to every random and super specific request that comes in. At the same time, I think candlestick charts are so common that it may make sense to consider supporting in some manner. I'd like to see a pathway for such a common chart to make it into the core project perhaps starting as an external chart. In the meantime, is there some other way for a candlestick plugin to become officially recognized such as living under the chartjs organization?

@etimberg
Copy link
Member

@benmccann we're happy to have someone write and maintain a candlestick plugin that could live in the chartjs organization. I would say that the best way to get started on something like that would be to create the chart and get it working well, then we can find a way to transfer the repository into the organization.

@benmccann
Copy link
Contributor

@mce1978 were you going to try this? I don't think anyone else has worked on it to answer your question

The floating bar chart has some similarity to the candlestick chart and potentially could be a good place to start: #4120

@benmccann
Copy link
Contributor

Thanks @etimberg !

@benmccann
Copy link
Contributor

We have a candlestick chart now: https://github.com/chartjs/chartjs-chart-financial

Feedback welcome

@yurtkuran
Copy link

@benmccann great, thanks! I'm kinda new to chart.js, how do I install it? TIA

@benmccann
Copy link
Contributor

I'm working on some improvements and cleanup still before the initial release. For now you would have to build it yourself

@nabtron
Copy link

nabtron commented Jun 22, 2017

how to build it ourselves?

@MeoMix
Copy link

MeoMix commented Jul 12, 2017

@benmccann Thanks for the work you've done so far on adding the financial / candle plugin.

You mention that there's improvements/cleanup to take place before initial release. I peeked at the open issue list and didn't see anything by you.

If you find the time to expand upon what needs to be accomplished for it to be taken to production, I might have the time to dig into some of it in the future. I've an interest in using the plugin and have decent experience working with the main library / contributing to OSS.

@benmccann
Copy link
Contributor

@MeoMix there's a description of the time scale cleanup (which is in progress) on the README: https://github.com/chartjs/chartjs-chart-financial

@MeoMix
Copy link

MeoMix commented Jul 12, 2017

@benmccann Great, thanks. Sorry for missing that!

@bob22cat22
Copy link

Looking forward to having candlesticks. Please don't let it evaporate.

@Giabanga
Copy link

me to!

@grantlittle
Copy link

+1 for that

@benmccann
Copy link
Contributor

We're just about to release 2.7.1 which has an additional set of time scale improvements and bug fixes to further improve the candlestick rendering

There's still some more work that I'm doing on the chart in 2.8.0. E.g. right now the tooltips don't work on the time scale. I'm trying to fix that in #4583

@rashearth
Copy link

Looking forward to having candlesticks for me too! cant wait!

@Xarialon
Copy link

Xarialon commented Aug 19, 2018

Still no Candlestick implementation! What are you lazy assholes doing!?

@eximius313
Copy link

@benmccann, are you planning to include candlestick chart into Chart.js core?

@benmccann
Copy link
Contributor

No, I'm not currently planning to include it in core. While I'd be happy to do so, I'm not sure that the change would be accepted as Chart.js aims to keep the core as small as possible and implement most features as external plugins. For now, I would recommend using https://github.com/chartjs/chartjs-chart-financial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests