Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Financial chart #4172

Closed
benmccann opened this issue Apr 24, 2017 · 8 comments
Closed

Financial chart #4172

benmccann opened this issue Apr 24, 2017 · 8 comments

Comments

@benmccann
Copy link
Contributor

I've been developing a financial chart here: https://github.com/benmccann/Chart.Financial.js

@etimberg mentioned that he'd be open to having it live under the chartjs group

I want to finish up some things before I publish the initial version to npm. However, I was wondering if you could create a fork under the chartjs group in the meantime while I work on polishing it up

@simonbrunel
Copy link
Member

@etimberg what do you thing to start normalizing the name of chart repositories (as we did for plugins) and create the fork under the following name: chartjs/chartjs-chart-financial? It would make obvious that chartjs-chart-* packages are targeting version 2 and other ones (Chart.*.js) mostly version 1.

@etimberg
Copy link
Member

@simonbrunel I like that idea since it matches what we did for plugins.

In terms of moving this under the org, would it be best to fork it into the org, or just transfer the repo?

@simonbrunel
Copy link
Member

Transfer the repo seems better!

@benmccann
Copy link
Contributor Author

I'm happy to transfer the repo. I will need permissions to create repositories in the chartjs organization in able to do so

Chart.BarFunnel.js and Chart.smith.js both depend on Chart.js 2.4.0. I can't easily tell what version Chart.LinearGauge.js is depending on because it doesn't utilize gulp & npm like the others (chartjs/Chart.LinearGauge.js#6)

So right now basically the pattern is that charts use the Chart.X.js naming convention and plugins use the chartjs-chart-X naming convention. So if we want to use that naming convention then we should probably rename the other chart repos as well

@simonbrunel
Copy link
Member

Agree, we should align other 2.x chart repository names. We can start with yours in chartjs/chartjs-chart-financial and rename the others later. Also think to change the name in package.json to gather all npm packages under chartjs-chart-*.

@benmccann
Copy link
Contributor Author

I sent you guys invites to the repo, but I don't think it'll allow you transfer rights. I think the only way will be to at least temporarily give me more rights in the chartjs group

@simonbrunel
Copy link
Member

simonbrunel commented Apr 24, 2017

I think Chart.LinearGauge.js is Chart.js 1.x?

@benmccann
Copy link
Contributor Author

Thanks. Closing this as done. Chart lives here now: https://github.com/chartjs/chartjs-chart-financial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants