-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve scale fitting logic and performance #6074
Labels
Comments
I agree to:
I don't think that auto skipping and auto rotation should be mutually exclusive. because after rotating, there might still be the need to skip. |
Closed by #6304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
core.layouts
callsscale.update
multiple times. This is unnecessary. We do not need to calculate theticks
multiple times for example. We should instead callfit
rather thanupdate
fit
,autoSkip
, andcalculateTickRotation
do not work well together_autoSkip
should probably happen inupdate
rather thandraw
. Right nowfit
assumes all ticks will be drawn, which isn't true whenautoSkip: true
The text was updated successfully, but these errors were encountered: