autoSkip support for calculateTickRotation #6075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
calculate-rotation-autoskip
branch
from
300bf5a
to
5b18f1c
Compare
benmccann
force-pushed
the
calculate-rotation-autoskip
branch
from
5b18f1c
to
fcc03a2
Compare
|
Rotation and auto skipping might not work too well together, but I don't think a "magic button" is the solution. If a user wants Just my opinion, feel free to disagree 👼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have autoSkip on then you can have
calculateTickRotationreturn 0. This addresses space constraints via auto-skipping instead of rotation. As a result, it leaves more room for the chart contents by keeping the scale height low since there's no rotation. The current logic is not cohesive and calculates thelabelRotationand_autoSkipindependently often coming up with results that are fairly sub-optimal when combinedCloses user reports #3981 and #5765. Closes my previous attempt #6072. Partially addresses #6074