Refactor filler plugin for easier maintenance#10040
Merged
kurkle merged 1 commit intochartjs:masterfrom Feb 12, 2022
Merged
Conversation
Member
Author
|
CC: 16 fixed, 11 new => 5 fixed issues. So only the file length issue in addition to #10039 |
Member
Author
|
LeeLenaleee
approved these changes
Jan 2, 2022
etimberg
approved these changes
Jan 2, 2022
Member
|
@kurkle is this safe to merge? |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10039 (includes it)
Quite extensive refactoring of the filler plugin