Correct chart initialization flow#10266
Merged
etimberg merged 2 commits intochartjs:masterfrom Mar 31, 2022
Merged
Conversation
etimberg
reviewed
Mar 29, 2022
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Should the draw.io file be updated as well?
Collaborator
Author
|
No, the .drawio file only has the render pipeline flowchart in it |
etimberg
previously approved these changes
Mar 29, 2022
Member
|
I'm surprised, I thought I put all of them in there. |
Collaborator
Author
|
MB, you did, did not notice the tabs at the bottom. Would have made live bit easyer since the png had the incorrect chart in its metadata 😅 Will update drawio file too |
etimberg
approved these changes
Mar 29, 2022
kurkle
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order in which hooks were called was wrong in flow chart
https://jsfiddle.net/Leelenaleee/pLj20hu4/11/