Document tooltip draw hooks and only call hooks when the tooltip draws#10276
Merged
etimberg merged 2 commits intochartjs:masterfrom Apr 3, 2022
Merged
Conversation
Collaborator
|
Technically it will be breaking since it can alter custom code that relied on it being fired every render cycle. But I think it should be considered a bug fix instead of a breaking change since in its current form for most usecasses if you want to use it you can't use it. |
kurkle
approved these changes
Apr 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10002
Not sure if this counts as a breaking change or not for the plugin.tooltip.js changes.