Correct auto.esm.js import to allow module to work in browser#10341
Merged
etimberg merged 1 commit intochartjs:masterfrom May 11, 2022
Merged
Correct auto.esm.js import to allow module to work in browser#10341etimberg merged 1 commit intochartjs:masterfrom
etimberg merged 1 commit intochartjs:masterfrom
Conversation
Contributor
kylejonesdev
commented
May 5, 2022
kylejonesdev
commented
- Added needed file extension to import statement
- Remedied the browser console error referenced in Import in auto.esm.js is wrong #10303
- Passed all tests
- No example attached because no practical change in functionality
su79eu7k
approved these changes
May 11, 2022
etimberg
approved these changes
May 11, 2022
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Approving since the build worked. I'm surprised other spots did not need their imports changed
kurkle
approved these changes
May 11, 2022
Member
There was a problem hiding this comment.
The PR title should be updated to something descriptive.
The helpers imported from dist/chart.esm.js seem to have the .js extension already and everything else is in that file. So I'm confident this change is really enough.
I don't see any benefits in importing the module version that way though, non-minimized and only some helpers extracted to separate bundle. But maybe I'm just missing something.
(the chart.min.js is ~69kb while the chart.esm.js is ~370kb)
etimberg
changed the title
Member
|
I've updated the title |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.