Skip to content

Add index to legendItem interface #10436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etimberg merged 2 commits into from
Jun 22, 2022
Merged

Add index to legendItem interface #10436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8397f85
Add index to legendItem interface for doughnut, pie and polarArea cha…
LeeLenaleee Jun 22, 2022
6f00c7e
Remove test to check if datasetIndex has been set in generateLabels f…
LeeLenaleee Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion types/index.esm.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2165,7 +2165,12 @@ export interface LegendItem {
/**
* Index of the associated dataset
*/
datasetIndex: number;
datasetIndex?: number;

/**
* Index the associated label in the labels array
*/
index?: number

/**
* Fill style of the legend box
Expand Down
7 changes: 0 additions & 7 deletions types/tests/plugins/defaults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,3 @@ defaults.plugins.legend.labels.generateLabels = function(chart) {
text: 'test'
}];
};

// @ts-expect-error Type '{ text: string; }[]' is not assignable to type 'LegendItem[]'.
defaults.plugins.legend.labels.generateLabels = function(chart) {
return [{
text: 'test'
}];
};