feat: remove line element from scatter controller

[thabarbados]

Make scatter chart not require the lineElement #10242

You can check the build with changes here

[LeeLenaleee]

Some weird animation behaviour. If you enable the showLine prop for Scatter Dataset 1 it will disable the animations of Scatter Dataset 2. This dataset will pop in with showLine true and false

[LeeLenaleee]

I think it would be better to not make these helper functions public, this means they can not be changed easily since people might rely on them. But as long as we keep them private they can be changed more easily in the future. And we can always make them public but making them private needs to wait for a major release

Also if you make them private there is no type declaration needed for them.

[thabarbados]

@LeeLenaleee, thanks for your review. I made helper functions private.

[thabarbados]

Hey folks! Is there anything else I need to do to approve this PR?

[LeeLenaleee]

I'm sorry, had little time because my graduation internship was comming to an end, I will look a or it tonight, should have time then

[LeeLenaleee]

Noticed that when you set showLine to true in the options object itself it will throw an error:
https://codesandbox.io/s/peaceful-forest-ttcudi?file=/src/components/ScatterChart.ts

[kurkle]

I'd like to explore the possibility to make the line element optional in the line controller. I'd think it would have smaller footprint overall, but am not sure.

[kurkle]

Needs a rebase still

[thabarbados]

Needs a rebase still

rebased

[etimberg]

@thabarbados it looks like the tests are consistently failing

[thabarbados]

@thabarbados it looks like the tests are consistently failing

fixed

[typpo]

Noticing that v3.9.0 altered scatter plots that set line properties such as fill: true, but did not set showLine: true.

I realize support without showLine was probably never intended, but I'm leaving a note here for posterity in case anyone else encounters this!

Simple test case:

{
  type: 'scatter',
  data: {
    datasets: [{
      data: [{x:1,y:1}, {x:2,y:2}],
      backgroundColor: '#de000055',
      fill: true,
    }]
  }
}

Before (3.8.2)

After (3.9.0)