Enforce maximum width on chart editor blocks in the docs#10447
Merged
kurkle merged 2 commits intochartjs:masterfrom Jun 29, 2022
Merged
Enforce maximum width on chart editor blocks in the docs#10447kurkle merged 2 commits intochartjs:masterfrom
kurkle merged 2 commits intochartjs:masterfrom
Conversation
3 tasks
kurkle
reviewed
Jun 28, 2022
etimberg
approved these changes
Jun 29, 2022
kurkle
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10416 (charts get overly large on high-resolution screens).
I've decided to enforce maximum width on.chart-editor(both chart preview and code editor) rather than.chart-viewbecause source code in the code editor seems to not be very lengthy anyway—but it looks better when chart preview match code editor width.Please see the preview on my 1800px-wide screen.
Before:
After:
